Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4579-y25-002---bug-duplicate-samples-per-pool-validations_v2 #4660

Conversation

wendyyang
Copy link
Contributor

Closes #

Changes proposed in this pull request

remove duplicate validation
remove duplicate error messages display

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (6d08266) to head (fd6bd42).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4660      +/-   ##
===========================================
- Coverage    89.41%   89.41%   -0.01%     
===========================================
  Files         1406     1406              
  Lines        30296    30263      -33     
===========================================
- Hits         27090    27059      -31     
+ Misses        3206     3204       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wendyyang wendyyang requested a review from yoldas February 3, 2025 22:17
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this removes the duplicate validation of pool sizes (in turn the redundant error messages listed for sequential pool numbers) and form level listing of all error messages (while they are already listed per control).

@wendyyang wendyyang merged commit 822d54b into develop Feb 6, 2025
23 checks passed
@wendyyang wendyyang deleted the origin/4579-y25-002---bug-duplicate-validations_for_scrna-cdna-prep-submission_v2 branch February 6, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y25-002 - [BUG] Duplicate Samples per Pool validations for scRNA cDNA Prep Submission
2 participants